reject extensions in a TLS 1.3 Certificate message that were not offered in the prior ClientHello/CertificateRequest#10338
Open
gasbytes wants to merge 1 commit intowolfSSL:masterfrom
Open
Conversation
…red in the prior ClientHello/CertificateRequest per rfc 8446 4.4.2
|
julek-wolfssl
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #10319
per RFC 8846 4.4.2 (https://www.rfc-editor.org/rfc/rfc8446.html#section-4.4.2)
"Extensions in the Certificate message from the client MUST correspond to extensions in the CertificateRequest message from the server."
added missing check in src/tls.c checking message type, tls version (must be tls 1.3) and call to find the extensions in the ssl object that were parsed in the previous clienthello and/or certificate requesst